Change arg max to max in Appendix D.#734
Merged
nicksavers merged 1 commit intoethereum:masterfrom Mar 28, 2019
Merged
Conversation
Here j is the maximum x such that there exists an \mathbf{l} such that etc. etc.
That is, j is the length of the longest common prefix of all the keys (nibble
arrays) of the \mathfrak{I} map.
Note that j is not the argument x that maximizes the value of a function over x.
The expression \exists \mathbf{l} ... following \arg \max is boolean-valued.
Also change a colon into a \wedge, which conjoins the two constraints over x and
\mathbf{l} in the set comprehension.
Contributor
|
For review. This changes the following into |
Member
Author
|
Thanks, @nicksavers. I'll add screenshots like yours to future PRs. |
Member
Author
|
@nicksavers, given that nobody has objected to the change, would you be willing to merge it? I'll mention that this change is based on a formal specification of Modified Merkle Patricia trees that I have developed in the ACL2 theorem prover, available on GitHub here. In particular, to calculate that index j, I used a max (not arg max) operator, in the function |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here j is the maximum x such that there exists an \mathbf{l} such that etc. etc.
That is, j is the length of the longest common prefix of all the keys (nibble
arrays) of the \mathfrak{I} map.
Note that j is not the argument x that maximizes the value of a function over x.
The expression \exists \mathbf{l} ... following \arg \max is boolean-valued.
Also change a colon into a \wedge, which conjoins the two constraints over x and
\mathbf{l} in the set comprehension.